rjmcmahon
/
umber-kernel
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

apparmor: fix boolean argument in apparmor_mmap_file 

[ Upstream commit 48d5268e911abcf7674ec33c9b0b3e952be1175e ]

The previous value of GFP_ATOMIC is an int and not a bool, potentially
resulting in UB when being assigned to a bool. In addition, the mmap hook
is called outside of locks (i.e. in a non-atomic context), so we can pass
a fixed constant value of false instead to common_mmap.

Signed-off-by: Ryan Lee <ryan.lee@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Stable-dep-of: 4a134723f9f1 ("apparmor: move check for aa_null file to cover all cases")
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ryan Lee 2026-01-07 11:48:54 -08:00 committed by Greg Kroah-Hartman
parent ac8f179e5c
commit 1eadeb462e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/apparmor/lsm.c
View File

@ -583,7 +583,7 @@ static int common_mmap(const char *op, struct file *file, unsigned long prot,
static int apparmor_mmap_file(struct file *file, unsigned long reqprot,
unsigned long prot, unsigned long flags)
{
return common_mmap(OP_FMMAP, file, prot, flags, GFP_ATOMIC);
return common_mmap(OP_FMMAP, file, prot, flags, false);
}
static int apparmor_file_mprotect(struct vm_area_struct *vma,